perf: Improve performance of PNG card imports #1008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors the PNG file reading process to improve performance, especially for large files on mobile devices. - In `persona.ts`, replaces the synchronous `PngChunk.read` with the asynchronous `PngChunk.readGenerator` to avoid blocking the main thread during persona imports. - In `pngChunk.ts`, the `readGenerator` is updated to use the `File.stream()` API. This provides a more efficient way to read local files, reducing memory overhead and processing time compared to the previous `File.slice()` and `FileReader` implementation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Description
Refactors the PNG file reading process to improve performance, especially for large files on mobile devices.
In
persona.ts, replaces the synchronousPngChunk.readwith the asynchronousPngChunk.readGeneratorto avoid blocking the main thread during persona imports.In
pngChunk.ts, thereadGeneratoris updated to use theFile.stream()API. This provides a more efficient way to read local files, reducing memory overhead and processing time compared to the previousFile.slice()andFileReaderimplementation.