Skip to content

Bump k8s.io/client-go to 1.28.2 #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2023
Merged

Bump k8s.io/client-go to 1.28.2 #806

merged 1 commit into from
Sep 14, 2023

Conversation

MartinForReal
Copy link
Contributor

@MartinForReal MartinForReal commented Sep 8, 2023 •
edited
Loading

bump k8s.io/client-go to 1.28.2 and resolve issues in go.mod

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 8, 2023
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 8, 2023
@MartinForReal
Copy link
Contributor Author

/assign @mmiranda96

@MartinForReal
Copy link
Contributor Author

/assign @vteratipally

hakman
hakman requested changes Sep 8, 2023
View reviewed changes
@MartinForReal
Copy link
Contributor Author

/assign @hakman

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2023
@MartinForReal MartinForReal changed the title Add dependabot config and bump dependencies Bump k8s.io/client-go to 1.28.2 Sep 14, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2023
@MartinForReal
Copy link
Contributor Author

@hakman @vteratipally Could you please take a look? Thanks!

@MartinForReal
Copy link
Contributor Author

/retest

@MartinForReal MartinForReal force-pushed the master branch 2 times, most recently from 607ce08 to f05f8c1 Compare September 14, 2023 03:38
hakman
hakman requested changes Sep 14, 2023
View reviewed changes
@MartinForReal
Copy link
Contributor Author

/test pull-npd-e2e-node

@hakman
Copy link
Member

hakman commented Sep 14, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2023
@vteratipally
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, MartinForReal, vteratipally

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2bb82fa into kubernetes:master Sep 14, 2023
This was referenced Sep 15, 2023
Closed
Merged
@MartinForReal MartinForReal mentioned this pull request Dec 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakman hakman hakman approved these changes

@sjenning sjenning Awaiting requested review from sjenning

@vteratipally vteratipally Awaiting requested review from vteratipally

Assignees

@hakman hakman

@mmiranda96 mmiranda96

@vteratipally vteratipally

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MartinForReal @hakman @vteratipally @k8s-ci-robot @mmiranda96