Add a check if the metric is nil so that collector doesn't collect metrics. #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
1 similar comment
|
/retest |
|
/test pull-npd-e2e-kubernetes-gce-gci |
|
/lgtm cancel |
/test pull-npd-e2e-kubernetes-gce-gci |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/assign @Random-Liu |
|
closes issue #614 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Random-Liu, vteratipally The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check if the metric is nil so that collector doesn't collect metrics.
NPD collects the metrics based on the input system-stats-monitor.json. If the metric config is present in the input, NPD shouldn't collect the metrics, but currently NPD still tries to collect the metrics even the metric is not present and which would result in nil pointer.
This should fix the issue.