Add healthChecker functionality for kube-proxy service #552
Conversation
|
Hi @mcshooter. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @jeremyje |
|
/ok-to-test |
| } | ||
|
|
||
| // healthCheckEndpointOKFunc returns a function to check the status of an http endpoint | ||
| func healthCheckEndpointOKFunc(endpoint string, timeout time.Duration) func() (bool, error) { |
There was a problem hiding this comment.
Seems like a missed opportunity to not make this generic health check through config. IE remove the hardcoded addresses and pass that in as a json argument.
/cc @Random-Liu what do you think?
There was a problem hiding this comment.
@Random-Liu what do you think?
Yeah, we thought about introducing the Kubernetes like "healthiness probe": Exec probe + http probe.
The only problem is that the health checker is already a plugin of NPD, and now we need another layer of plugin. :P
Some design is needed here.
Please feel free to suggest ideas or propose a design for this, but that doesn't necessarily need to block this change.
1b79ad9 to
01cd8dd
Compare
|
/retest |
|
@mcshooter this seems can be extended to support other windows services like csi-proxy which is installed in the same place? cc @ddebroy |
@jingxu97 I am not too familiar with what csi-proxy is, but if it's similar to kubelet and kube-proxy and having csi-proxy being down would cause the node to become unhealthy, then yes, it should be something that NPD should be able to support. |
| } | ||
|
|
||
| // healthCheckEndpointOKFunc returns a function to check the status of an http endpoint | ||
| func healthCheckEndpointOKFunc(endpoint string, timeout time.Duration) func() (bool, error) { |
There was a problem hiding this comment.
@Random-Liu what do you think?
Yeah, we thought about introducing the Kubernetes like "healthiness probe": Exec probe + http probe.
The only problem is that the health checker is already a plugin of NPD, and now we need another layer of plugin. :P
Some design is needed here.
Please feel free to suggest ideas or propose a design for this, but that doesn't necessarily need to block this change.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mcshooter, Random-Liu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There have been some customer complaints that on windows node start ups, that when kube-proxy fails to start, some pods pods were entering into a crashloop state as services were inaccessible. Adding functionality to detect when kube-proxy is down, can attempt to repair the service and prevent pods from entering into a crashloop state.