Generate new status log only on condition change #441
Conversation
|
Hi @abansal4032. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc Random-Liu |
| } | ||
| glog.V(3).Infof("Receive new plugin result for %s: %+v", c.configPath, result) | ||
| status := c.generateStatus(result) | ||
| glog.Infof("New status generated: %+v", status) |
There was a problem hiding this comment.
Can we keep this line with lower log level?
| Events: append(activeProblemEvents, inactiveProblemEvents...), | ||
| Conditions: c.conditions, | ||
| } | ||
| // Log only if condition has changed for permanent error |
There was a problem hiding this comment.
Can we check whether activeProblemEvents and inactiveProblemEvents are empty? I think that should cover all cases.
There was a problem hiding this comment.
Switched to checking for active and inactive problems. They so cover all the cases.
c792a44 to
f80f3e0
Compare
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abansal4032, Random-Liu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is to limit the logging from custom plugin runs. Today every run is logged with the status, we can instead log the status only when there is a change in conditions.