Update the detection method for docker overlay2 issue #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @Random-Liu |
Random-Liu
reviewed
Aug 2, 2019
config/docker-monitor.json
Outdated
| "bufferSize": 10, | ||
| "source": "docker-monitor", | ||
| "metricsReporting": true, | ||
| "conditions": [], |
| "source": "docker-monitor", | ||
| "metricsReporting": true, | ||
| "conditions": [], | ||
| "conditions": [ |
|
Remove the one from docker-monitor-counter.json? |
I cannot remove it now. The presubmit and CI jobs are using k8s master head to test NPD e2e tests, which needs docker-monitor-counter.json. We can remove this config file after updating the k8s master. |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Random-Liu, wangzhen127 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 13, 2019
Cherry pick #321 to v0.6: Update the detection method for docker overlay2 issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the detection method for docker overlay2 issue. We no longer count how many times the log message is seen.