-
Notifications
You must be signed in to change notification settings - Fork 495
Self-nominate pbundyra as a dependency-approver and a test-approver #8259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
+1, thank you for the contributions so far. Thank you 👍 Having more test and dependency approvers will help to offload the top-level approvers. /lgtm |
|
LGTM label has been added. DetailsGit tree hash: 09956df8305f3a8568a429ebde22783693b27e11 |
tenzen-y
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely, thank you! 💯
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PBundyra, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-0.15 |
|
Thank you! |
|
@PBundyra: new pull request created: #8272 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@PBundyra: new pull request created: #8273 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
I believe that I've met all of the requirements, and would like to self-nominate as a Kueue Approver for dependencies go.mod, go.sum and tests.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?