Skip to content

Conversation

@ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Mar 11, 2025

Closes #8690

@headius
Copy link
Member

headius commented Mar 11, 2025

Could you rebase this on the jruby-9.4 branch? We should fix it there as well.

@headius headius added this to the JRuby 9.4.13.0 milestone Mar 11, 2025
@ccutrer
Copy link
Contributor Author

ccutrer commented Mar 11, 2025

I'm not sure the current state of things with 9.4 and 10. Do you want a separate PR for 9.4, or just re-target this one to 9.4?

@headius
Copy link
Member

headius commented Mar 12, 2025

We always merge forward so changes to 9.4 will get into master/10.

Are the .project changes necessary for the AutoCloseable? If not, what are they for? Probably should be a separate PR if it's unrelated.

@ccutrer
Copy link
Contributor Author

ccutrer commented Mar 12, 2025

Are the .project changes necessary for the AutoCloseable?

Nope, that was probably just VSCode doing something weird, and I didn't notice them when I did git commit -a.

@ccutrer ccutrer force-pushed the jruby-engine-autocloseable branch from da16e60 to 15912d6 Compare March 12, 2025 19:14
@ccutrer ccutrer changed the base branch from master to jruby-9.4 March 12, 2025 19:14
@ccutrer
Copy link
Contributor Author

ccutrer commented Mar 12, 2025

Okay, this PR now targets 9.4, and I removed the spurious project changes.

@enebo enebo merged commit e0de6e1 into jruby:jruby-9.4 Mar 12, 2025
57 of 74 checks passed
@enebo
Copy link
Member

enebo commented Mar 12, 2025

@ccutrer Thanks for putting this together. Our CI did not rerun on jruby-9.4 for unknown reasons but this should be fine on jruby-9.4 (10 is still not quite fully green yet).

@ccutrer ccutrer deleted the jruby-engine-autocloseable branch March 12, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using JSR223 ScriptEngine interface has no way to clean up resources

3 participants