Unlock if poll triggers an exception #8586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRuby semantics for an interrupt during lock appear to ensure that the lock is released before propagating any interrupt exception. This poll was added without such behavior, leading to locks being left locked even though a thread interrupt happened. This in turn breaks some semantics of Mutex#synchronize, since the lock call does not happen within the try/finally that would release it, so any exception raised will exit synchronize with the lock still locked. The fix here wraps the additional poll with try/catch to ensure poll-triggered exceptions release the lock before propagating. Fixes jruby#8585
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRuby semantics for an interrupt during lock appear to ensure that the lock is released before propagating any interrupt exception. This poll was added without such behavior, leading to locks being left locked even though a thread interrupt happened. This in turn breaks some semantics of Mutex#synchronize, since the lock call does not happen within the try/finally that would release it, so any exception raised will exit synchronize with the lock still locked.
The fix here wraps the additional poll with try/catch to ensure poll-triggered exceptions release the lock before propagating.
Fixes #8585