Skip to content

Conversation

@kares
Copy link
Member

@kares kares commented Nov 25, 2024

includes updated BC version and two small bug-fixes for better compatibility with libraries such as JWT:

https://github.com/jruby/jruby-openssl/releases/tag/v0.15.2

... and more compatibility fixes in 0.15.3 (some towards the secure gem publisher such as jruby/jruby-openssl#298)

https://github.com/jruby/jruby-openssl/releases/tag/v0.15.3

@kares kares added this to the JRuby 9.4.10.0 milestone Nov 25, 2024
@headius
Copy link
Member

headius commented Nov 25, 2024

Seems to be OpenSSL-related failures in test:mri:stdlib. Old tests?

@kares
Copy link
Member Author

kares commented Nov 26, 2024

yeah, noticed they are kind of "expected" due the checks the suite has: if openssl?(3, 0, 0)

JOSSL isn't really OpenSSL 3.0 compatible, but the OPENSSL_VERSION_NUMBER was set in a way that got the if openssl?(3, 0, 0) to return true. now it's set to return a version < 3.0.0 as this actually matters with libraries out there (tested with https://github.com/jwt/ruby-jwt).

so, it's a bit of a mess, guess we could wait a while before having this one included in JRuby for user reports or I will eventually find time to address those failures (so that at least OpenSSL 1.x compatibility is more reliable).

@headius
Copy link
Member

headius commented Jan 15, 2025

@kares This is ready to go then yes?

@kares
Copy link
Member Author

kares commented Jan 18, 2025

Feel free to postpone, another release is almost ready with more stuff that has been requested (and also resolves most of the "new" test failures here).l, but it might take me some time to release...

@headius
Copy link
Member

headius commented Jan 18, 2025

@kares okay thanks for the update. Let me know if there's any way I can help.

@kares kares changed the title [deps] bump jruby-openssl to 0.15.2 [deps] bump jruby-openssl to 0.15.3 Jan 19, 2025
@headius
Copy link
Member

headius commented Jan 21, 2025

Based on conversation on Matrix I believe this is ready to merge, and 9.4.10.0 is out so we'll have this in 9.4.11.0.

@headius headius merged commit 74bc2bb into jruby:master Jan 21, 2025
95 checks passed
@kares kares deleted the jossl-0.15.2 branch January 21, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants