Eliminate last consumers of Variable logic #8293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getInstanceVariableNameList doesn't create extra Variable objects, but it does create a list that's usually just iterated and discarded. We can do it a bit cheaper with a forEach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will replace the remaining uses of the
Variablecollections returned by methods likeInstanceVariables.getInstanceVariableListso we can start deprecating those interfaces and fix users in the wild.getInstanceVariableListreplaced withforEachInstanceVariable, eliminating a transientMapofVariableobjects.getInstanceVariableNameListreplaced withforEachInstanceVariableName, eliminating a transientList<String>.Most of these do allocate a stateful Lambda, but I've made efforts to keep that cost to a minimum.