Rewrite Marshal.dump logic for efficiency #8260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshalStream holds a lot of state and requires allocation of a large number of objects just to dump a graph of Ruby objects. This is a first step toward passing more of that state on the stack and enabling zero-allocation dumping of all object types.
This eliminates all remaining usage of the Variable collection from RubyBasicObject.getMarshalVariables. Includes some additional cleanup and refactored logic.
Avoid creating all those Integer objects.
Additional improvements here: * rubyName no longer reverses the parents list before iterating. * Factored out common path string-building logic. * Smaller initial parents list (more than 5 parents is very rare).
There's only one way to do it so just save the context in the stream.
Two lambdas for dumping variables is two too many. This reduces it to one.
This is the first of many globally-used symbols to be added to the SymbolTable. This commit also moves creation of the SymbolTable to just after the creation of the Symbol class, so these global symbols can be final references.
If not captured immediately, contained objects will be dumped and clear this state, breaking the variable count just acquired.
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Marshal.dump logic we have predates nearly all improvements we have made over time, including:
This PR refactors and overhauls MarshalStream for efficiency and reduced object allocation.