Skip to content

Replace ostruct with a custom class that acts almost the same. #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

Replace ostruct with a custom class that acts almost the same. #2106

merged 1 commit into from
Oct 2, 2025

Conversation

jordansissel
Copy link
Owner

@jordansissel jordansissel commented Oct 2, 2025 •
edited
Loading

This removes a warning in 3.4.0 and prepares for Ruby 3.5.0; this warning only appeared when loading lib/fpm/rake_task.rb

warning: ostruct was loaded from the standard library, but will no longer
be part of the default gems since Ruby 3.5.0. Add ostruct to your Gemfile or gemspec.

This seems preferable to adding ostruct as a gem dependency especially since older rubies may not support the gem version of ostruct.

@jordansissel
Replace ostruct with a custom class that acts almost the same.
71890ac 
This removes a warning in 3.4.0 and prepares for Ruby 3.5.0:
> warning: ostruct was loaded from the standard library, but will no longer
> be part of the default gems since Ruby 3.5.0. Add ostruct to your Gemfile or gemspec.

This seems preferable to adding ostruct as a gem dependency especially
since older rubies may not support the gem version of ostruct.
@jordansissel
Copy link
Owner Author

Honestly, not sure anyone uses FPM::RakeTask anymore. I was thinking about removing it, but the code to replace ostruct was fast enough to write that I'm not worried about deleting it right now.

% bundle exec rspec -fd -e Rake
Run options: include {:full_description=>/Rake/}

FPM::RakeTask
  #new
    requires a package name
    requires a source
    requires a target
    requires package args
    executes FPM::Command with the appropriate arguments

Finished in 0.00741 seconds (files took 0.29507 seconds to load)
5 examples, 0 failures

@jordansissel jordansissel merged commit c6069f5 into main Oct 2, 2025
0 of 4 checks passed
@jordansissel jordansissel mentioned this pull request Oct 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jordansissel