Allow set-and-delete flow that is usually used by acme-clients #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuxgemini
added a commit
to linuxgemini/acme-dns
that referenced
this pull request
Feb 9, 2022
Co-authored-by: İlteriş Yağıztegin Eroğlu <[email protected]> Signed-off-by: İlteriş Yağıztegin Eroğlu <[email protected]>
linuxgemini
added a commit
to linuxgemini/acme-dns
that referenced
this pull request
Feb 9, 2022
Co-authored-by: Yannik Sembritzki <[email protected]> Signed-off-by: İlteriş Yağıztegin Eroğlu <[email protected]>
|
I haven't yet deployed acme-dns, so maybe I'm missing something, but I don't see why more than two TXT records per account are necessary. Just use a different acme-dns account for each subdomain. |
tjmullicani
added a commit
to tjmullicani/acme-dns
that referenced
this pull request
Mar 22, 2023
jmartindf
referenced
this pull request
in jmartindf/acme-dns
Jun 8, 2024
Support deleting txt records (jacobmyers-codeninja) Allow set-and-delete flow that is usually used by acme-clients (Yannik) Fix linter issues (Yannik) Signed-off-by: Joe Martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the work of @jacobmyers-codeninja's PR #245 and fully implements set-and-delete flow.
This fixes issues such as dehydrated-io/dehydrated#832