Fix: CFFI build now uses relative paths #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CFFI build process was previously using absolute paths to the source and include directories, which caused the resulting wheel to be non-portable. This was because was being used in . This commit removes the calls and uses relative paths instead. This ensures that the CFFI build process creates a portable wheel that can be installed on any machine.
The CFFI build was failing in CI because the relative paths to the source and include directories were not being resolved correctly when pip executed the build in a temporary directory. This commit fixes the issue by using to construct absolute paths to the required files, ensuring they can be found regardless of the current working directory.
|
Resolves #386 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CFFI build process was previously using absolute paths to the source and include directories, which caused the resulting wheel to be non-portable.
This commit uses relative paths instead. This ensures that the CFFI build process creates a portable wheel that can be installed on any machine.