Improve debug log fields when executing requests #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a336766 to
f6ddf0e
Compare
Collaborator
|
You can rebase on master, #24 should have fix the CI |
Author
|
Done! |
stormshield-gt
approved these changes
Dec 13, 2024
Collaborator
|
Thanks for your contribution! |
Author
|
No, thank you for accepting it and your work on this library! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First: this is a fantastic library, thank you! <3
One issue we've run into is that the logs are quite verbose. This MR makes the (very useful) sending/receiving
debug!calls add fields with the method, status, uri, status and content length.This enables one to set a logging directive like
rustify::client[{success=false}]=debugto log all unsuccessful requests to the console, whilst skipping successful ones.I also moved some verbose
executing endpointdebug!calls to betrace!instead.