Skip to content

Conversation

@IonGyth
Copy link

@IonGyth IonGyth commented Apr 6, 2018

No description provided.

@IonGyth IonGyth closed this Apr 6, 2018
@IonGyth IonGyth reopened this Apr 6, 2018
@jk2K
Copy link
Owner

jk2K commented Apr 7, 2018

thanks, Can you give a screenshot and show the effect of this commit?

@IonGyth
Copy link
Author

IonGyth commented Apr 12, 2018

Firstly, thanks for responding. I'm not very familiar with GitHub so bare with me! Just to give you some information about why this was required.
Steps to replicate:

  1. Click "Show" for either a Request or a Response
    1a. The box should drop down with Headers, Attributes, Body, and Schema,
  2. Click "Show" for the Schema
  3. The Schema should not show

I found this was because when clicking this the "max-height" style attribute was set on "collapse-content" but since the "JsonSchemaContent" was hidden then it could not get the height of that div.

I'll be more than happy to provide screenshots if you request it but I'm not sure if they will add much!

@IonGyth
Copy link
Author

IonGyth commented Apr 12, 2018

Oh, I also made this change on the olio-theme branch then merged that into publish-patch-for-olio-theme. I don't really want to create two pull requests with basically the same thing but once you're happy with everything then maybe you could merge it into there.

I'll take your guidance on what you think is best for that.

@IonGyth
Copy link
Author

IonGyth commented Apr 18, 2018

Hey! What do you think?

@jk2K jk2K merged commit d9d7cfd into jk2K:olio-theme Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants