Refactor Scan Pull Request to accept PR ID as input #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sverdlov93
reviewed
Jul 25, 2023
Contributor
sverdlov93
left a comment
There was a problem hiding this comment.
not finished the review yet
| if g.PullRequestID, err = strconv.Atoi(pullRequestIDString); err != nil { | ||
| return err | ||
| if g.PullRequestID == UndefinedPrID { | ||
| if idStr := getTrimmedEnv(GitPullRequestIDEnv); idStr != "" { |
Contributor
There was a problem hiding this comment.
why PullRequestID can't be string?
Contributor
Author
There was a problem hiding this comment.
The API accepts ID as an int ( froggit-go )
sverdlov93
reviewed
Jul 26, 2023
| var vulnerabilitiesRows []formats.VulnerabilityOrViolationRow | ||
| var iacRows []formats.IacSecretsRow | ||
| targetBranch := repoConfig.Branches[0] | ||
| targetBranch := pullRequestDetails.Target.Name |
Contributor
There was a problem hiding this comment.
pullRequestDetails.Target can't be nil?
pullRequestDetails.Source cant be nil?
Contributor
Author
There was a problem hiding this comment.
They can be empty with default values, but they cannot be nil.
Contributor
Contributor
Contributor
Contributor
1 similar comment
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
scan-pull-requestcommand to accept PR ID as input instead of relying on context.scan-pull-requests commandto use the singularscan-pull-requestThis will allow to use scan pull requests command with Jenkins webhook trigger, providing the pull request ID.
Jenkins Webhook Docs Update PR:
#399
Update:
When pull request origin from a forked repository, we need to know the owner in order to access the source code.
jfrog/froggit-go#102