Skip to content

Add informative error for unsupported technologies in create-fix-pull-requests #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 19, 2023
Merged

Add informative error for unsupported technologies in create-fix-pull-requests #392

merged 5 commits into from
Jul 19, 2023

Conversation

@omerzi
Copy link
Member

@omerzi omerzi commented Jul 16, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Opening a pull request that fixes vulnerabilities is currently not supported for Gradle, NuGet/.NET
  • For these technologies, we added an informative error.

Fixes:
#391

@omerzi omerzi requested a review from sverdlov93 July 16, 2023 05:40
@omerzi omerzi temporarily deployed to frogbot July 16, 2023 05:40 — with GitHub Actions Inactive
@omerzi omerzi changed the base branch from master to dev July 16, 2023 05:40
@omerzi omerzi added bug Something isn't working safe to test Approve running integration tests on a pull request labels Jul 16, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2023

2 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2023

@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 19, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 19, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 19, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 19, 2023
@omerzi omerzi merged commit 667d35f into jfrog:dev Jul 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023

@omerzi omerzi deleted the fix-unsupported-techs branch July 23, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sverdlov93 sverdlov93 sverdlov93 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@omerzi @sverdlov93