Separate env params extraction by context #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sverdlov93
approved these changes
Aug 13, 2023
Contributor
sverdlov93
pushed a commit
to sverdlov93/frogbot
that referenced
this pull request
Aug 13, 2023
sverdlov93
added a commit
that referenced
this pull request
Aug 15, 2023
* improve docs * improve docs * improve docs * improve docs * improve docs * improve docs * improve docs * Improve internal field names (#418) * Fix aggregate PRs test (#420) * Fix open pull request against the wrong branch (#421) * Update Git Action dependencies (#427) * Update git action * Update git action * Update git action --------- Co-authored-by: Omer Zidkoni <[email protected]> * Restructure source code (#419) * Fix mock import (#429) * Fix undefined pull request ID in scan-pull-requests (#428) * Upgrade golang.org/x/net to 0.13.0 (#430) * Remove base branch from github actions (#431) * Separate env params extraction by context (#432) * Update dependencies (#435) * Update git action * Update git action * Update git action * Update git action * Update git action * Update git action * Update git action * Update git action * Unify webhook url markdown * Update scan-pull-request.jenkinsfile * Update scan-repository.jenkinsfile * Update scan-pull-request.jenkinsfile * add jenkins pipeline logo * move position * change image * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update install-github.md * Delete jenkins-logo.png * Update README.md * Update README.md * Update README.md * Update git action * Update git action --------- Co-authored-by: Omer Zidkoni <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Eyal Delarea <[email protected]> Co-authored-by: Omer Zidkoni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description:
ScanRepository params validation interfere with ScanPullRequest command while trying to get branches related params.
Fix:
Env params extraction should behave different depending on command context.
We assume the context of the command by the pull request ID param. If it is set, we assume we are in ScanPullRequest context, otherwise we are in ScanRepository context.
When in the context of ScanPullRequest, no need to extract branches related env vars.
In the context of ScanRepository, extract branches, git templates and aggregate fixes flag, which are all unrelated to the second context.