Skip to content

Improve GetUniqueID #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 2, 2023
Merged

Improve GetUniqueID #408

merged 2 commits into from
Aug 2, 2023

Conversation

@omerzi
Copy link
Member

@omerzi omerzi commented Aug 1, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@omerzi omerzi added the improvement Automatically generated release notes label Aug 1, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Aug 1, 2023
@omerzi omerzi requested a review from sverdlov93 August 1, 2023 13:31
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 1, 2023
@omerzi omerzi temporarily deployed to frogbot August 2, 2023 06:56 — with GitHub Actions Inactive
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Aug 2, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

@omerzi omerzi merged commit c4cc942 into jfrog:dev Aug 2, 2023
@omerzi omerzi deleted the update-core-changes branch August 2, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sverdlov93 sverdlov93 sverdlov93 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

improvement Automatically generated release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@omerzi @sverdlov93