Skip to content

Avoid deleting comments if none are found #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 31, 2023
Merged

Avoid deleting comments if none are found #406

merged 8 commits into from
Jul 31, 2023

Conversation

@omerzi
Copy link
Member

@omerzi omerzi commented Jul 31, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@omerzi omerzi added the bug Something isn't working label Jul 31, 2023
@omerzi omerzi requested a review from sverdlov93 July 31, 2023 07:42
sverdlov93
sverdlov93 reviewed Jul 31, 2023
View reviewed changes
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 31, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 31, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 31, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 31, 2023
@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jul 31, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 31, 2023
@omerzi omerzi temporarily deployed to frogbot July 31, 2023 09:03 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023

@omerzi omerzi merged commit edf2268 into jfrog:dev Jul 31, 2023
@omerzi omerzi deleted the avoid-delete-if-no-comment branch July 31, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sverdlov93 sverdlov93 sverdlov93 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@omerzi @sverdlov93