Skip to content

🐛 fix(front_matter): correct error handling for post length #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 26, 2025
Merged

🐛 fix(front_matter): correct error handling for post length #617

merged 4 commits into from
Jul 26, 2025

Conversation

gortavoher
Copy link
Collaborator

  • rename PostTooCharacters to PostTooManyCharacters for clarity

@gortavoher
🐛 fix(front_matter): correct error handling for post length
ac9b391 
- fix typo in error variant from `PostTooCharacters` to `PostTooManyCharacters`
- unify tag joining logic by using `bluesky_tags()` method
@gortavoher
🐛 fix(error): correct typo in error variant
aa40540 
- rename PostTooCharacters to PostTooManyCharacters for clarity
@gortavoher gortavoher requested a review from jerusdp as a code owner July 26, 2025 06:23
@gortavoher gortavoher self-assigned this Jul 26, 2025
@gortavoher gortavoher changed the title Correct-error-handling-for-post-length 🐛 fix(front_matter): correct error handling for post length Jul 26, 2025
@jerusdp jerusdp enabled auto-merge July 26, 2025 06:25
@codecov Codecov
Copy link

codecov bot commented Jul 26, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../cli/bsky/commands/cmd_draft/draft/front_matter.rs 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
...ommands/cmd_draft/draft/front_matter/taxonomies.rs 80.95% <ø> (ø)
src/error.rs 0.00% <ø> (ø)
.../cli/bsky/commands/cmd_draft/draft/front_matter.rs 93.06% <50.00%> (-0.03%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gortavoher
💄 style(taxonomies): allow dead code for hashtags function
a034288 
- add #[allow(dead_code)] attribute to suppress warnings for hashtags function
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jerusdp jerusdp merged commit e33a5c1 into main Jul 26, 2025
2 checks passed
@jerusdp jerusdp deleted the correct-error-handling-for-post-length branch July 26, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerusdp jerusdp jerusdp approved these changes

Assignees

@gortavoher gortavoher

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gortavoher @jerusdp @jerus-bot