Skip to content

DNM [vjp3] Make value_and_grad always use f_vjp.with_refs(*accums) #32470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −3
Draft

DNM [vjp3] Make value_and_grad always use f_vjp.with_refs(*accums) #32470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions jax/_src/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,12 +497,18 @@ def value_and_grad_f(*args, **kwargs):
for leaf in tree_leaves(dyn_args):
_check_input_dtype_grad(holomorphic, allow_int, leaf)
if not has_aux:
ans, vjp_py = _vjp(f_partial, *dyn_args)
ans, vjp_py = _vjp3(f_partial, *dyn_args)
else:
ans, vjp_py, aux = _vjp(f_partial, *dyn_args, has_aux=True)
ans, vjp_py, aux = _vjp3(f_partial, *dyn_args, has_aux=True)
_check_scalar(ans)
tree_map(partial(_check_output_dtype_grad, holomorphic), ans)
g = vjp_py(lax_internal._one(ans))

# g = vjp_py(lax_internal._one(ans))

grad_accum = tree_map(lambda x: core.new_ref(lax_internal._zeros(x)), dyn_args)
vjp_py.with_refs(*grad_accum)(lax_internal._one(ans))
g = tree_map(lambda x: core.freeze(x), grad_accum)

g = g[0] if isinstance(argnums, int) else g
if not has_aux:
return ans, g
Expand Down
Loading