Skip to content

[mosaic] Removed the deprecated tpu.wait_dma op #32445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
Merged

[mosaic] Removed the deprecated tpu.wait_dma op #32445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jax/_src/pallas/mosaic/verification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ def _print_op(ctx, op):
f" {src.length}, {dst_location[0]}, {dst_location[1]},"
f" {dst_sem.base}, {dst.base}, {dst.length})",
)
case "tpu.wait_dma":
case "tpu.wait_dma2":
sem_model = ctx.get(op.semaphore)
sem = sem_model.at(location=None)
ctx.emit(None, f"atomic {{ {sem} >= 1; {sem} = {sem} - 1 }}")
Expand Down
9 changes: 0 additions & 9 deletions jaxlib/mosaic/dialect/tpu/tpu.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1185,15 +1185,6 @@ def TPU_WaitDMA2Op : TPU_Op<"wait_dma2", [AttrSizedOperandSegments]> {
];
}

// TODO(b/395630795): Remove after 2025-08-10.
def TPU_WaitDMAOp : TPU_Op<"wait_dma"> {
let arguments = (ins
MemRefOf<[TPU_DMASemaphoreType]>:$semaphore,
AnyMemRef:$ref
);
let hasVerifier = 1;
}

// Like tpu.wait_dma2, but for indirect DMAs.
//
// The number of bytes to wait for is determined based on the size of the
Expand Down
9 changes: 0 additions & 9 deletions jaxlib/mosaic/dialect/tpu/tpu_ops.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1540,15 +1540,6 @@ LogicalResult EnqueueIndirectDMAOp::verify() {
/*operand_ty=*/target_ty);
}

// TODO(b/395630795): Remove after 2025-08-10.
LogicalResult WaitDMAOp::verify() {
auto sem_type = getMemRefType(getSemaphore());
if (sem_type.getRank() != 0) {
return emitOpError("DMA wait semaphore must be rank 0");
}
return success();
}

void WaitDMA2Op::build(OpBuilder &builder, OperationState &state,
Value semaphore, Value src, Value dst) {
build(builder, state, semaphore, src, dst, /*device_id=*/nullptr,
Expand Down
3 changes: 0 additions & 3 deletions jaxlib/mosaic/dialect/tpu/transforms/memory_space_specialization.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,6 @@ LogicalResult specializeMemorySpace(TypedValue<MemRefType> value,
if (auto op = dyn_cast<tpu::EnqueueDMAOp>(some_op)) {
continue; // Nothing to do.
}
if (auto op = dyn_cast<tpu::WaitDMAOp>(some_op)) {
continue; // Nothing to do.
}
if (auto op = dyn_cast<tpu::WaitDMA2Op>(some_op)) {
continue; // Nothing to do.
}
Expand Down
Loading