[Mosaic GPU][NFC] Derive smem_buffer_ptr in OnDeviceProfiler.record.
#32442
+8
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c1dc27 to
5a1059b
Compare
We would like to wrap the profiler initialisation logic in `CustomPrimitiveOp`. Moving the convertion from memref to pointer out of the constructor means we don't need to extend `CustomPrimitiveOp` to support returning pointers. PiperOrigin-RevId: 817542981
5a1059b to
8f6a72d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Mosaic GPU][NFC] Derive
smem_buffer_ptrinOnDeviceProfiler.record.We would like to wrap the profiler initialisation logic in
CustomPrimitiveOp. Moving the convertion from memref to pointer out of the constructor means we don't need to extendCustomPrimitiveOpto support returning pointers.