Skip to content

Fix a concurrency problem in jax_explain_cache_misses. #31850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

Fix a concurrency problem in jax_explain_cache_misses. #31850

merged 1 commit into from
Sep 17, 2025

Conversation

hawkinsp
Copy link
Collaborator

Fixes #30163

@hawkinsp hawkinsp requested a review from yashk2810 September 16, 2025 20:37
yashk2810
yashk2810 requested changes Sep 16, 2025
View reviewed changes
Copy link
Collaborator

@yashk2810 yashk2810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test please?

@hawkinsp
Copy link
Collaborator Author

Add a test please?

Done.

@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Sep 16, 2025
@copybara-service copybara-service bot merged commit 72e4734 into jax-ml:main Sep 17, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashk2810 yashk2810 yashk2810 approved these changes

Assignees
No one assigned
Labels
kokoro:force-run pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jax_explain_cache_misses is not thread safe
2 participants
@hawkinsp @yashk2810