Clarify wait_recv semantics
#30000
Open
Clarify wait_recv semantics
#30000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
I'm new to distributed Pallas kernels and for a long time was confused when reading the documentation, incorrectly assuming `wait_recv` means waiting until the target device has received the data. In fact I believe it means waiting until the current device has received the data (which is presumably sent from yet another third device that is neither the current device nor the target device in the all-gather example).
|
@mattjj do you know if someone could take a look at this PR? Thanks! |
|
@justinjfu can you take a look when you have a moment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm new to distributed Pallas kernels and for a long time was confused when reading the documentation, incorrectly assuming
wait_recvmeans waiting until the target device has received the data. In fact I believe it means waiting until the current device has received the data (which is presumably sent from yet another third device that is neither the current device nor the target device in the all-gather example).This is my attempt at clarifying this potential misconception.