-
Notifications
You must be signed in to change notification settings - Fork 3.2k
JEP 18137: Scope of JAX NumPy & SciPy Wrappers #18137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
26d684f
to
6217974
Compare
6217974
to
123f0f7
Compare
First of all I'd like to thank the JAX team for your efforts. You guys are my heros! Our group is currently using JAX to develop underwater mapping software. We have found it great to easily convert existing code from standard numpy / scipy to JAX. Part of the reason why I wrote the The main thing I'd like to question is Is there a more explicit way to determine whether or not a class implementation is acceptable? Like a checklist or something? For example I'm wondering what the issue with the
For the I had submitted a PR for the Think short term it totally makes sense that you guys are trying to find ways to live within your available resources. However it makes me wonder if the long term vision is really to avoid implementing most of the numpy / scipy API? Some of this stuff seems like it could help other people port existing code to JAX (e.g. |
This document is an attempt to write down the long-term vision. We have never intended to implement the entire numpy/scipy API as part of the core JAX package (though of course we would welcome partner projects which implement parts of it that don't fit into jax itself). For example, if the optax loss function needs a cubic hermite spline, is there any reason not to implement that spline functionality in optax? |
I closed the |
If you guys want to remove |
d7d0a1c
to
5ae5e56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
a404320
to
d623d04
Compare
This is adds a JAX Enhancement Proposal (JEP) discussing the scope of NumPy & SciPy wrappers going forward. Comments welcome!
Rendered preview: https://jax--18137.org.readthedocs.build/en/18137/jep/18137-numpy-scipy-scope.html