Skip to content

jnp.bitwise_count: fix issue with unsigned ints #17962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2023
Merged

jnp.bitwise_count: fix issue with unsigned ints #17962

merged 1 commit into from
Oct 6, 2023

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Oct 5, 2023 •
edited
Loading

Fixes #17949

lax.abs is incompatible with unsigned ints, but abs works for any input type.

@jakevdp jakevdp requested a review from hawkinsp October 5, 2023 17:56
@jakevdp jakevdp self-assigned this Oct 5, 2023
@jakevdp jakevdp force-pushed the fix-bitwise-count branch from c6e66b3 to cc62314 Compare October 5, 2023 18:01
@jakevdp jakevdp force-pushed the fix-bitwise-count branch from cc62314 to cd18f8e Compare October 5, 2023 21:00
@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Oct 6, 2023
@copybara-service copybara-service bot merged commit 6681e64 into jax-ml:main Oct 6, 2023
@jakevdp jakevdp deleted the fix-bitwise-count branch October 6, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkinsp hawkinsp hawkinsp approved these changes

Assignees

@jakevdp jakevdp

Labels

pull ready Ready for copybara import and testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

⚠️ Nightly upstream-dev CI failed ⚠️

3 participants

@jakevdp @hawkinsp @kokoro-team