Skip to content

[sparse] implement iter() of BCOO #13263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2022
Merged

[sparse] implement iter() of BCOO #13263

merged 1 commit into from
Nov 15, 2022

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Nov 15, 2022 •
edited
Loading

This is important because Python's default implementation of __iter__ in this case is an infinite loop 😱

@jakevdp jakevdp requested a review from froystig November 15, 2022 21:18
@jakevdp jakevdp self-assigned this Nov 15, 2022
@jakevdp jakevdp added the pull ready Ready for copybara import and testing label Nov 15, 2022
@copybara-service copybara-service bot merged commit d9e4058 into jax-ml:main Nov 15, 2022
@jakevdp jakevdp deleted the bcoo-iter branch November 16, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@froystig froystig froystig approved these changes

Assignees

@jakevdp jakevdp

Labels

pull ready Ready for copybara import and testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jakevdp @froystig @kokoro-team