Form a tree of concatenations in jax.numpy.concatenate. #920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ingle wide concatenation. Wide concatenations can be slow to compile, particularly on the CPU backend. Benchmark: %time np.array(list(range(10000))) Wall time before: 24.6s Wall time after: 0.86s. (This still isn't great, but it's much better!)
mattjj
approved these changes
Jun 25, 2019
|
This is much much better! Thanks @hawkinsp for fixing this bug! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wide concatenations can be slow to compile, particularly on the CPU backend. As a workaround particularly for op-by-op mode, form a tree of narrower concatenations.
Fixes #653
Benchmark:
%time np.array(list(range(10000)))
Wall time before: 24.6s
Wall time after: 0.86s.
(This still isn't great, but it's much better!)