Skip to content

make jax.random default dtypes 64-bit #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2019
Merged

make jax.random default dtypes 64-bit #761

merged 2 commits into from
May 23, 2019

Conversation

mattjj
Copy link
Collaborator

@mattjj mattjj commented May 22, 2019

fixes #756

@mattjj mattjj mentioned this pull request May 22, 2019
Closed
fehiepsi
fehiepsi reviewed May 23, 2019
View reviewed changes
Copy link
Contributor

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattjj ! All the changes look good to me. I just have a few minor comments on this. :)

@mattjj mattjj merged commit 2409a74 into master May 23, 2019
@mattjj mattjj deleted the issue756 branch May 23, 2019 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fehiepsi fehiepsi fehiepsi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make samplers in jax.random use float64 as default when jax_enable_x64=True

3 participants

@mattjj @fehiepsi @googlebot