feat(hooks): Provide static getHook method for access to all html-webpack-plugin hooks #995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ooflorent
approved these changes
Jul 6, 2018
…pack-plugin hooks BREAKING CHANGE: The html-webpack-plugin doesn't add its hooks to the compilation object anymore
59c8e8f to
4a96a9c
Compare
|
Okay changed it to getHooks - will rename it again to |
|
This feels like a great change, in my opinion. The access to hooks feels much cleaner. |
sokra
reviewed
Jul 9, 2018
| hooks.htmlWebpackPluginAfterEmit = new AsyncSeriesWaterfallHook(['pluginArgs']); | ||
| function createHtmlWebpackPluginHooks () { | ||
| return { | ||
| htmlWebpackPluginBeforeHtmlGeneration: new AsyncSeriesWaterfallHook(['pluginArgs']), |
There was a problem hiding this comment.
You should consider removing the htmlWebpackPlugin prefix, as it's now already namespace via getHooks.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export all hooks static and typed similar to webpack/webpack#7672
cc @ooflorent