-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(connector): [checkout] Add additional fields in the request #9888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changed Files
|
af13e48 to
23c4948
Compare
crates/hyperswitch_connectors/src/connectors/checkout/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/checkout/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/worldpayvantiv/transformers.rs
Outdated
Show resolved
Hide resolved
| pub customer_email: Option<common_utils::pii::Email>, | ||
| pub customer_name: Option<Secret<String>>, | ||
| pub customer_phone_number: Option<Secret<String>>, | ||
| pub customer_phone_country_code: Option<String>, | ||
| pub shipping_details: Option<AddressDetails>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we structure the L2L3Data to have different structs for customer_details, shipping_details etc instead of having all the fields as part of L2L3Data struct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that would be better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can take this change in the next PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case please create and issue and mention it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the issue for it : #9912
…pay#9888) Co-authored-by: Vani Gupta <[email protected]> Co-authored-by: likhinbopanna <[email protected]>
Co-authored-by: Vani Gupta <[email protected]> Co-authored-by: likhinbopanna <[email protected]>
Type of Change
Description
Providing additional data in the request to improve acceptance rate.

Also, updated the shipping_details and customer details in the L2L3 data.
for instance, earlier we were passing only customer name to the connector, now introduced email and phone field as well in L2L3 data.
Additional Changes
Motivation and Context
How did you test it?
Request:
Response:
Checklist
cargo +nightly fmt --allcargo clippy