Skip to content

fix: Update events table after notifying merchant #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jarnura merged 2 commits into from
Apr 17, 2023
Merged

fix: Update events table after notifying merchant #871

jarnura merged 2 commits into from
Apr 17, 2023

Conversation

@SamraatBansal
Copy link
Contributor

@SamraatBansal SamraatBansal commented Apr 13, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

Update the is_webhook_notified column in events table after an outgoing Webhook notification is successfully triggered.

Additional Changes

  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

After triggering Webhook notification, db was not getting updated to record that a successful notification has been delivered to the merchant.

How did you test it?

Triggered Webhooks and accordingly based on outgoing Webhook notification, observed the changes in events table.

Screenshot 2023-04-13 at 12 24 40 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SamraatBansal SamraatBansal added A-core Area: Core flows C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 13, 2023
@SamraatBansal SamraatBansal self-assigned this Apr 13, 2023
@SamraatBansal SamraatBansal requested review from a team as code owners April 13, 2023 07:12
vspecky
vspecky suggested changes Apr 13, 2023
View reviewed changes
Narayanbhat166
Narayanbhat166 suggested changes Apr 13, 2023
View reviewed changes
@jarnura jarnura added this to the April'23 release milestone Apr 14, 2023
@jarnura jarnura added the S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners label Apr 17, 2023
vspecky
vspecky approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@vspecky vspecky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamraatBansal SamraatBansal added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners labels Apr 17, 2023
@jarnura jarnura added this pull request to the merge queue Apr 17, 2023
Merged via the queue into main with commit ba01302 Apr 17, 2023
@SanchithHegde SanchithHegde deleted the bugfix/update_webhook_event_db branch April 17, 2023 19:28
@Gnanasundari24 Gnanasundari24 mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jarnura jarnura jarnura approved these changes

+2 more reviewers

@vspecky vspecky vspecky approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SamraatBansal SamraatBansal

Labels

A-core Area: Core flows C-bug Category: Bug

Projects

No open projects
hyperswitch - Public Roadmap
Status: Merged

Milestone

April 2023 Release

Development

Successfully merging this pull request may close these issues.

6 participants

@SamraatBansal @jarnura @vspecky @Narayanbhat166 @SanchithHegde