Skip to content

chore: update org retrieve api response to include org type #8660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
likhinbopanna merged 9 commits into from
Jul 18, 2025
Merged

chore: update org retrieve api response to include org type #8660

likhinbopanna merged 9 commits into from
Jul 18, 2025

Conversation

@gitanjli525
Copy link
Contributor

@gitanjli525 gitanjli525 commented Jul 16, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Updated organization_retrieve api response to contain organization_type for v1 and v2 api

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Curl for Organization Retrieve

curl --location 'http://localhost:8080/organization/org_nib3yNnE0BcUJJ8ptlh2' \
--header 'api-key: test_admin' \
--header 'Content-Type: application/json'

Current response

{
    "organization_id": "org_nib3yNnE0BcUJJ8ptlh2",
    "organization_name": "org_local",
    "organization_details": null,
    "metadata": null,
    "modified_at": "2025-07-15 15:47:00.992814",
    "created_at": "2025-07-15 15:47:00.992762",
}

Updated response

{
    "organization_id": "org_nib3yNnE0BcUJJ8ptlh2",
    "organization_name": "org_local",
    "organization_details": null,
    "metadata": null,
    "modified_at": "2025-07-15 15:47:00.992814",
    "created_at": "2025-07-15 15:47:00.992762",
    "organization_type": "standard"
}

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@gitanjli525 gitanjli525 self-assigned this Jul 16, 2025
@gitanjli525 gitanjli525 requested a review from a team as a code owner July 16, 2025 07:14
@semanticdiff-com
Copy link

semanticdiff-com bot commented Jul 16, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/openapi/src/openapi.rs  22% smaller
  crates/openapi/src/openapi_v2.rs  22% smaller
  api-reference/v1/openapi_spec_v1.json  0% smaller
  api-reference/v2/openapi_spec_v2.json  0% smaller
  crates/api_models/src/organization.rs  0% smaller
  crates/common_enums/src/enums/accounts.rs  0% smaller
  crates/router/src/types/api/admin.rs  0% smaller

@gitanjli525 gitanjli525 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed M-api-contract-changes Metadata: This PR involves API contract changes labels Jul 16, 2025
@hyperswitch-bot hyperswitch-bot bot removed the M-api-contract-changes Metadata: This PR involves API contract changes label Jul 16, 2025
@gitanjli525 gitanjli525 linked an issue Jul 16, 2025 that may be closed by this pull request
Update get organization details api response to contain organization type #8666
Closed
@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Jul 16, 2025
su-shivanshmathur
su-shivanshmathur reviewed Jul 18, 2025
View reviewed changes
crates/api_models/src/organization.rs
/// Organization Type of the organization
#[schema(value_type = Option<OrganizationType>, example = "standard")]
pub organization_type: Option<OrganizationType>,
}
Copy link
Contributor

@su-shivanshmathur su-shivanshmathur Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you need to have a OpenAPI documentation for the OrganizationType as well ?

Copy link
Contributor Author

@gitanjli525 gitanjli525 Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, updated PR @su-shivanshmathur

@likhinbopanna likhinbopanna added this pull request to the merge queue Jul 18, 2025
@tsdk02 tsdk02 removed this pull request from the merge queue due to a manual request Jul 18, 2025
@likhinbopanna likhinbopanna enabled auto-merge July 18, 2025 09:54
@likhinbopanna likhinbopanna added this pull request to the merge queue Jul 18, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jul 18, 2025
@gitanjli525 @hyperswitch-bot
chore: update org retrieve api response to include org type (#8660)
0dbd279 
Co-authored-by: Gitanjli Chopra <[email protected]>
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Merged via the queue into main with commit a75af8b Jul 18, 2025
16 of 20 checks passed
@likhinbopanna likhinbopanna deleted the update-org-retrieve-response branch July 18, 2025 12:18
@hyperswitch-bot hyperswitch-bot bot removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jul 20, 2025
pixincreate added a commit that referenced this pull request Jul 22, 2025
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into connector/p…
1f9c871 
…ayload-recurring

* 'main' of github.com:juspay/hyperswitch: (48 commits)
  fix(connector): Add Trustpay in Authentication Providers Config (#8622)
  refactor(connector): [Adyen] map ssn and session validity for Pix (#8702)
  feat(core): Implement UCS kill switch for emergency fallback (#8651)
  fix(openapi): Added Error Response Schema for Status Code 400 (#8684)
  feat(connector): Add template code for breadpay (#8655)
  chore(version): 2025.07.21.1
  refactor(payments): fetch payment method information in attempts list api v2 and add custom billing connector template (#8681)
  fix(router): Make v2 endpoints follow standard naming conventions (#8630)
  fix(connector): [Cybersource] Add type_selection_indicator as 1 for all cards  (#8663)
  feat(routing): Add API key auth for decision engine endpoints (#8640)
  feat(authentication): Added eligibility flow for modular authentication (#8431)
  feat(connector): [BLACKHAWKNETWORK] Add Template Code  (#8632)
  fix: remove straight through routing from routing approach (#8695)
  fix(connector): [Access Worldpay] correct enum deserialization for payment responses for (#8689)
  chore(version): 2025.07.21.0
  feat(debit_routing): add debit routing support for apple pay (#8673)
  refactor(router): decrypt the wallet token before the debit routing call (#8598)
  chore: update org retrieve api response to include org type (#8660)
  feat(routing): Add routing evaluation rule endpoint and related flow (#8656)
  fix(connector): [AUTHORIZEDOTNET] Added Invoice Number Fix (#8685)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@su-shivanshmathur su-shivanshmathur su-shivanshmathur left review comments

@tsdk02 tsdk02 tsdk02 approved these changes

@ShankarSinghC ShankarSinghC ShankarSinghC approved these changes

Assignees

@gitanjli525 gitanjli525

Labels

M-api-contract-changes Metadata: This PR involves API contract changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update get organization details api response to contain organization type

6 participants

@gitanjli525 @tsdk02 @ShankarSinghC @su-shivanshmathur @likhinbopanna