Skip to content

feat(router): adding metrics for tracking behavior throughout the router crate #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jarnura merged 4 commits into from
Mar 21, 2023
Merged

feat(router): adding metrics for tracking behavior throughout the router crate #768

jarnura merged 4 commits into from
Mar 21, 2023

Conversation

@NishantJoshi00
Copy link
Contributor

@NishantJoshi00 NishantJoshi00 commented Mar 20, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

This PR focuses on adding metrics to the router crate.

review-note: consider going through the metrics.rs file before reviewing the rest of the PR, while will provide more context while reviewing the rest of the code

Additional Changes

  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@NishantJoshi00 NishantJoshi00 added A-core Area: Core flows A-infra Area: Infrastructure S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Mar 20, 2023
@NishantJoshi00 NishantJoshi00 self-assigned this Mar 20, 2023
@NishantJoshi00 NishantJoshi00 requested review from a team as code owners March 20, 2023 06:32
lsampras
lsampras approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@lsampras lsampras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the most part

Can we also add a list of metrics in the PR description to help reviewers,

Also wondering if we can add a metricCounter trait so we can just do metric.increment() instead of metric.add(context, 1, &[])