refactor: add better log to parse struct #621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narayanbhat166
commented
Feb 20, 2023
|
|
||
| impl<T> BytesExt<T> for bytes::Bytes { | ||
| fn parse_struct<'de>(&'de self, type_name: &str) -> CustomResult<T, errors::ParsingError> | ||
| fn parse_struct<'de>(&'de self, _type_name: &str) -> CustomResult<T, errors::ParsingError> |
Contributor
Author
There was a problem hiding this comment.
Do we need to take type from the caller? I think we need to rely on the type system to provide the type name instead of asking the caller to provide, which is prone to error.
jarnura
approved these changes
Feb 25, 2023
lsampras
approved these changes
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Provide details on why parsing the struct failed by logging the raw bytes along with the type name which was intended to be converted to.
Motivation and Context
There were many cases where the response handling was failing because of deserialization problem. This will ease up debugging by providing relevant information.
How did you test it?
Create a payment ( or any request where it is sure that it will fail ) and check the logs.
Example of a checkout connector.
Checklist
cargo +nightly fmt --allcargo clippy