feat(router): added incoming refund webhooks flow #683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanchithHegde
requested changes
Feb 28, 2023
Member
SanchithHegde
left a comment
There was a problem hiding this comment.
Other than that, looks good to me!
crates/router/src/connector/adyen.rs
Outdated
Comment on lines
737
to
740
| "AUTHORISATION" => api::IncomingWebhookEvent::PaymentIntentSuccess, | ||
| "REFUND" => api::IncomingWebhookEvent::RefundSuccess, | ||
| "CANCEL_OR_REFUND" => api::IncomingWebhookEvent::RefundSuccess, | ||
| "REFUND_FAILED" => api::IncomingWebhookEvent::RefundFailure, |
Member
There was a problem hiding this comment.
If these event codes have been documented on their docs, please convert this to an enum instead.
Comment on lines
146
to
150
| CREATE TYPE "EventClass" AS ENUM ('payments', 'refunds'); | ||
|
|
||
| CREATE TYPE "EventObjectType" AS ENUM ('payment_details'); | ||
| CREATE TYPE "EventObjectType" AS ENUM ('payment_details', 'refund_details'); | ||
|
|
||
| CREATE TYPE "EventType" AS ENUM ('payment_succeeded'); | ||
| CREATE TYPE "EventType" AS ENUM ('payment_succeeded', 'refund_succeeded', 'refund_failed'); |
Member
There was a problem hiding this comment.
Please add new migrations for these changes.
Member
There was a problem hiding this comment.
Please revert changes made to this old migrations file.
Comment on lines
992
to
1002
| #[derive(Debug, Deserialize)] | ||
| pub enum WebhookEventCode { | ||
| #[serde(rename = "AUTHORISATION")] | ||
| Authorisation, | ||
| #[serde(rename = "REFUND")] | ||
| Refund, | ||
| #[serde(rename = "CANCEL_OR_REFUND")] | ||
| CancelOrRefund, | ||
| #[serde(rename = "REFUND_FAILED")] | ||
| RefundFailed, | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| #[derive(Debug, Deserialize)] | |
| pub enum WebhookEventCode { | |
| #[serde(rename = "AUTHORISATION")] | |
| Authorisation, | |
| #[serde(rename = "REFUND")] | |
| Refund, | |
| #[serde(rename = "CANCEL_OR_REFUND")] | |
| CancelOrRefund, | |
| #[serde(rename = "REFUND_FAILED")] | |
| RefundFailed, | |
| } | |
| #[derive(Debug, Deserialize)] | |
| #[serde(rename_all = "SCREAMING_SNAKE_CASE") | |
| pub enum WebhookEventCode { | |
| Authorisation, | |
| Refund, | |
| CancelOrRefund, | |
| RefundFailed, | |
| } |
SanchithHegde
previously approved these changes
Feb 28, 2023
Member
SanchithHegde
left a comment
There was a problem hiding this comment.
Apart from the pg_enum table being modified in the down.sql file, looks good to me!
vspecky
suggested changes
Feb 28, 2023
Comment on lines
992
to
1000
| #[derive(Debug, Deserialize)] | ||
| #[serde(rename_all = "SCREAMING_SNAKE_CASE")] | ||
| pub enum WebhookEventCode { | ||
| Authorisation, | ||
| Refund, | ||
| CancelOrRefund, | ||
| RefundFailed, | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Derive strum::Display and annotate with #[strum(serialize_all = "SCREAMING_SNAKE_CASE")] to get a display implementation.
crates/router/src/connector/adyen.rs
Outdated
|
|
||
| let message = format!( | ||
| "{}:{}:{}:{}:{}:{}:{}:{}", | ||
| "{}:{}:{}:{}:{}:{}:{:?}:{}", |
Contributor
There was a problem hiding this comment.
Use a display implementation for event_code
SanchithHegde
previously approved these changes
Feb 28, 2023
dracarys18
suggested changes
Feb 28, 2023
crates/router/src/connector/adyen.rs
Outdated
Comment on lines
736
to
742
| Ok(match notif.event_code { | ||
| adyen::WebhookEventCode::Authorisation => { | ||
| api::IncomingWebhookEvent::PaymentIntentSuccess | ||
| } | ||
| adyen::WebhookEventCode::Refund => api::IncomingWebhookEvent::RefundSuccess, | ||
| adyen::WebhookEventCode::CancelOrRefund => api::IncomingWebhookEvent::RefundSuccess, | ||
| adyen::WebhookEventCode::RefundFailed => api::IncomingWebhookEvent::RefundFailure, |
Contributor
There was a problem hiding this comment.
This can be converted to From implementation?
jarnura
previously approved these changes
Feb 28, 2023
dracarys18
previously approved these changes
Feb 28, 2023
jarnura
approved these changes
Feb 28, 2023
dracarys18
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Type of Change
Description
Added support for incoming refund webhooks.
Additional Changes
Motivation and Context
How did you test it?
Manually tested
Webhook Request
Outgoing webhook to merchant
Checklist
cargo +nightly fmt --allcargo clippy