-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(connector): [Paypal] implement vaulting for paypal wallet and cards while purchasing #5323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fde6085 to
19cb59c
Compare
…pal-wallet-vaulting-while-purchasing
41b8e3d to
6020ff0
Compare
1b93889 to
1d46cab
Compare
8ce2657 to
6020ff0
Compare
…pal-wallet-vaulting-while-purchasing
e1e5cfc to
7a23d81
Compare
79d3ea7 to
4e3bb00
Compare
eda1dc5 to
0ad1603
Compare
7f60ea2 to
b6bcb25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can make this a Secret if this is considered sensitive information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this different from CardVaultStruct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we okay with sending empty strings for name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we okay with doing nothing when we receive an error? Can we at least log it?
b3b0316
c334ce5
Type of Change
Description
This PR implements Vaulting while purchasing(Mandate flows) for Paypal connector for Card, Paypal redirection and Paypal SDK payment methods.
Additional Changes
Motivation and Context
How did you test it?
Response
Check for
payment_method_idin responseResponse
response:
Check for
payment_method_idin responseComplete the payment using redirect url.
request:
response:
Checklist
cargo +nightly fmt --allcargo clippy