feat: add track_caller to functions that perform change_context
#592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanchithHegde
approved these changes
Feb 14, 2023
dracarys18
approved these changes
Feb 14, 2023
jarnura
approved these changes
Feb 15, 2023
SamraatBansal
pushed a commit
that referenced
this pull request
Feb 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ntext
Type of Change
Description
This change works on improving the error tracking from the stack trace, currently for some errors tracking the exact error location was difficult because of the wrapper over them. This change adds
#[track_caller]to such functions allowing the actual call_site to be trackedAdditional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy