fix(connector): [Paypal]fix paypal error reason mapping when it is empty string. #2700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Error reason mapping in paypal fails when
descriptionfor error reason is empty string .Because current implementation usesthen_some, which returns Some(t) if the bool is [true], or None otherwise. Soerror_reasonalways set toNone.This pr fixes this issue and set the error reason to paypal's error message if error reason is empty string.Additional Changes
Motivation and Context
How did you test it?
Can't test this if paypal sends empty string in
PaypalPaymentErrorResponse -> details -> descriptionthen this will be mapped toPaypalPaymentErrorResponse-> message. Although it have same test case as this pr #2611 to test the previous error mapping .Checklist
cargo +nightly fmt --allcargo clippy