Skip to content

Conversation

@Chethan-rao
Copy link
Contributor

@Chethan-rao Chethan-rao commented Oct 10, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR includes changes for removing the requires cvv config from configs table when merchant account is deleted.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Chethan-rao Chethan-rao added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels Oct 10, 2023
@Chethan-rao Chethan-rao added this to the September 2023 Milestone milestone Oct 10, 2023
@Chethan-rao Chethan-rao requested a review from a team as a code owner October 10, 2023 08:03
@Chethan-rao Chethan-rao self-assigned this Oct 10, 2023
@Chethan-rao Chethan-rao linked an issue Oct 10, 2023 that may be closed by this pull request
2 tasks
@Chethan-rao Chethan-rao requested a review from vspecky October 10, 2023 09:14
@Narayanbhat166 Narayanbhat166 added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit b968552 Oct 11, 2023
@Narayanbhat166 Narayanbhat166 deleted the remove_cvv_config branch October 11, 2023 06:23
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-refactor Category: Refactor

Projects

No open projects
Status: Merged

Development

Successfully merging this pull request may close these issues.

[REFACTOR] delete requires cvv config when merchant account is deleted

7 participants