Skip to content

feat(db): implement MandateInterface for MockDb #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SanchithHegde merged 25 commits into from
Jun 17, 2023
Merged

feat(db): implement MandateInterface for MockDb #1387

SanchithHegde merged 25 commits into from
Jun 17, 2023

Conversation

@nachiketkanore
Copy link
Contributor

@nachiketkanore nachiketkanore commented Jun 8, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@nachiketkanore nachiketkanore requested a review from a team as a code owner June 8, 2023 09:43
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jun 8, 2023
@nachiketkanore nachiketkanore changed the title Mandate interface mock db feat: Implement MandateInterface for MockDB Jun 8, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jun 8, 2023
@NishantJoshi00 NishantJoshi00 added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jun 9, 2023
SanchithHegde
SanchithHegde reviewed Jun 11, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good to me!

@nachiketkanore nachiketkanore force-pushed the mandate-interface-mock-db branch from 3838f19 to c415ca4 Compare June 11, 2023 13:34
SanchithHegde
SanchithHegde reviewed Jun 13, 2023
View reviewed changes
@SanchithHegde SanchithHegde added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jun 13, 2023
@SanchithHegde SanchithHegde changed the title feat: Implement MandateInterface for MockDB feat(db): implement MandateInterface for MockDb Jun 13, 2023
@SanchithHegde SanchithHegde added the A-framework Area: Framework label Jun 13, 2023
SanchithHegde
SanchithHegde previously approved these changes Jun 15, 2023
View reviewed changes
@SanchithHegde SanchithHegde added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jun 15, 2023
@SanchithHegde SanchithHegde enabled auto-merge June 15, 2023 10:10
@SanchithHegde SanchithHegde disabled auto-merge June 15, 2023 10:18
NishantJoshi00
NishantJoshi00 suggested changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@NishantJoshi00 NishantJoshi00 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, otherwise

@inventvenkat inventvenkat added the low-risk label to track PRs which might have less impact on hyperswitch after merge label Jun 16, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue Jun 17, 2023
@SanchithHegde
Copy link
Member

SanchithHegde commented Jun 17, 2023

Thanks for the PR, @nachiketkanore!

@SanchithHegde SanchithHegde added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jun 17, 2023
Merged via the queue into juspay:main with commit 2555c37 Jun 17, 2023
@SanchithHegde SanchithHegde removed S-ready-for-merge low-risk label to track PRs which might have less impact on hyperswitch after merge labels Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

+1 more reviewer

@NishantJoshi00 NishantJoshi00 NishantJoshi00 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nachiketkanore nachiketkanore

Labels

A-core Area: Core flows A-framework Area: Framework C-feature Category: Feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement MandateInterface for MockDb

5 participants

@nachiketkanore @SanchithHegde @NishantJoshi00 @inventvenkat @niteshballa