Skip to content

feat(traces): add support for aws xray #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jarnura merged 2 commits into from
May 18, 2023
Merged

feat(traces): add support for aws xray #1194

jarnura merged 2 commits into from
May 18, 2023

Conversation

@lsampras
Copy link
Contributor

@lsampras lsampras commented May 17, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Add support for AWS X-ray
  • Users can now export traces to AWS X-ray via their otel-collector service

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

This provides an alternative for people for traces as well as provides an quick solution for users who don't wanna setup tempo

How did you test it?

  • Running it on an AWS ec2 instance

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@lsampras lsampras added C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed M-configuration-changes Metadata: This PR involves configuration changes R-waiting-on-L1 labels May 17, 2023
@lsampras lsampras self-assigned this May 17, 2023
@lsampras lsampras requested a review from a team as a code owner May 17, 2023 16:20
@lsampras lsampras requested review from a team, SanchithHegde and jarnura May 17, 2023 16:20
@jarnura jarnura enabled auto-merge May 18, 2023 08:15
@jarnura jarnura added this pull request to the merge queue May 18, 2023
Merged via the queue into main with commit 8947e1c May 18, 2023
@SanchithHegde SanchithHegde deleted the support_aws_xray branch May 18, 2023 19:14
@SanchithHegde SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 labels May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jarnura jarnura jarnura approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@lsampras lsampras

Labels

C-feature Category: Feature request or enhancement M-configuration-changes Metadata: This PR involves configuration changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lsampras @jarnura @SanchithHegde