Skip to content

refactor: use strum::EnumString implementation for connector name conversions #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SanchithHegde merged 31 commits into from
May 19, 2023
Merged

refactor: use strum::EnumString implementation for connector name conversions #1052

SanchithHegde merged 31 commits into from
May 19, 2023

Conversation

@nachiketkanore
Copy link
Contributor

@nachiketkanore nachiketkanore commented May 4, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

  • added 3 unit tests supporting the change

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@nachiketkanore nachiketkanore requested a review from a team as a code owner May 4, 2023 13:23
nachiketkanore and others added 2 commits May 4, 2023 19:02