feat: encrypt PII fields before saving it in the database #1043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nishant Joshi <[email protected]>
Co-authored-by: Nishant Joshi <[email protected]>
| .into_inner() | ||
| .expose(); | ||
|
|
||
| assert!(dummy_data_returned == dummy_data) |
Member
There was a problem hiding this comment.
Use assert_eq!() instead.
| use error_stack::{report, FutureExt, ResultExt}; | ||
| use masking::Secret; | ||
| use storage_models::{enums, merchant_account}; | ||
| use masking::Secret; //PeekInterface |
Member
There was a problem hiding this comment.
Suggested change
| use masking::Secret; //PeekInterface | |
| use masking::Secret; |
jarnura
approved these changes
May 30, 2023
inventvenkat
approved these changes
May 30, 2023
| merchant_id: merchant_id.to_string(), | ||
| ..Default::default() | ||
| }) | ||
| .change_context(errors::ApiErrorResponse::AddressNotFound)?; |
Member
There was a problem hiding this comment.
This change raises an incorrect error message that the address was not found, when in reality, the deseriliazation of the address failed. Could you please fix this, and ensure that "resource not found" errors are not being raised incorrectly elsewhere?
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds support for encrypting PII fields in following tables
Here's how the basic flow goes, the main encryption key
master_keywill be encrypted with KMS and configured indevelopment.toml. For every merchant we will create seperate encryption key and encrypt that key withmaster_keyand push it to the database and we will use that key to encrypt the PII fields.This PR also has migration script that will migrate currently decrypted database to encrypted database.
Additional Changes
Motivation and Context
This is for GDPR compliance for saving PII data in an encrypted format.
How did you test it?
Manual
Checklist
cargo +nightly fmt --allcargo clippy