Skip to content

refactor: add serde rename_all for refund enums #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SanchithHegde merged 1 commit into from
Jun 22, 2023
Merged

refactor: add serde rename_all for refund enums #1520

SanchithHegde merged 1 commit into from
Jun 22, 2023

Conversation

@Chethan-rao
Copy link
Contributor

@Chethan-rao Chethan-rao commented Jun 22, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR adds a serde rename_all attribute to refund enums (RefundStatus, RefundType)

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Chethan-rao Chethan-rao added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels Jun 22, 2023
@Chethan-rao Chethan-rao self-assigned this Jun 22, 2023
@Chethan-rao Chethan-rao requested a review from a team as a code owner June 22, 2023 14:33
@SanchithHegde SanchithHegde added this pull request to the merge queue Jun 22, 2023
@SanchithHegde SanchithHegde added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jun 22, 2023
Merged via the queue into main with commit 0c86243 Jun 22, 2023
@SanchithHegde SanchithHegde deleted the add_serde_for_refund branch June 22, 2023 15:28
Chethan-rao added a commit that referenced this pull request Jun 28, 2023
@Chethan-rao
refactor: add serde rename_all for refund enums (#1520)
78a348e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

+1 more reviewer

@lsampras lsampras lsampras approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Chethan-rao Chethan-rao

Labels

C-refactor Category: Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Chethan-rao @lsampras @SanchithHegde