Skip to content

fix(configs): remove pix and twint from pm_filters for adyen #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SanchithHegde merged 4 commits into from
Jun 22, 2023
Merged

fix(configs): remove pix and twint from pm_filters for adyen #1509

SanchithHegde merged 4 commits into from
Jun 22, 2023

Conversation

@hrithikesh026
Copy link
Contributor

@hrithikesh026 hrithikesh026 commented Jun 22, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Removed pix and twint from from adyen's pm_filter

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@hrithikesh026 hrithikesh026 requested a review from a team as a code owner June 22, 2023 11:33
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jun 22, 2023
@hrithikesh026 hrithikesh026 changed the title Pm filters adyen changes fix: pm filters adyen changes Jun 22, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jun 22, 2023
@hrithikesh026 hrithikesh026 changed the title fix: pm filters adyen changes fix(configs): remove pix and twint from pm_filters for adyen Jun 22, 2023
@SanchithHegde SanchithHegde merged commit c1e8ad1 into main Jun 22, 2023
@SanchithHegde SanchithHegde deleted the pm_filters_adyen_changes branch June 22, 2023 12:09
@hrithikesh026 hrithikesh026 added the M-configuration-changes Metadata: This PR involves configuration changes label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

Assignees

@hrithikesh026 hrithikesh026

Labels

M-configuration-changes Metadata: This PR involves configuration changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hrithikesh026 @SanchithHegde @sai-harsha-vardhan @Narayanbhat166